Skip to content

Conversation

@kfdm
Copy link
Contributor

@kfdm kfdm commented Dec 11, 2025

Several tools like uv now support dependency groups to separate from other optional-dependencies. Adding the test requirements there. Ideally this would replace the values in [test] but seems like it's only supported in Python 3.13 +

I was hoping I could also use this to simplify the ci.yml as well, but seems like --groups for pip doesn't work in 3.12 only 3.13 >=

Had wanted to add this so that a Makefile/Justfile could be added so that make test or just test could trigger pytest more easily, but may need to research it a bit more.

Trying to insure that I can easily test locally before I tried to make another PR 🙃

Several tools like `uv` now support dependency groups to separate from
other optional-dependencies. Adding the test requirements there. Ideally
this would replace the values in [test] but seems like it's only supported
in Python 3.13 +
@codingjoe codingjoe self-requested a review December 16, 2025 17:37
@codingjoe
Copy link
Owner

Hi @kfdm,

Fancy meeting you here! 😄
Yes, I have succumbed to the UV hype train too. No objections from my side, but we might want to use this opportunity for a little more magic.

Would you care to add a test group and let dev inherit it?
Furthermore, I'd be cool to actually switch the CI jobs to use UV to manage dependencies.

If you are busy with other things, no worries. I can give you a hand.

Cheers!
Joe

@codingjoe codingjoe removed their request for review December 16, 2025 17:39
@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.76%. Comparing base (d827484) to head (e7c6851).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage   97.76%   97.76%           
=======================================
  Files           5        5           
  Lines         134      134           
=======================================
  Hits          131      131           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

We let the dev group include test by default, and move the test group
from optional-dependencies to dependency-groups to have a single source
of truth.
@kfdm
Copy link
Contributor Author

kfdm commented Dec 17, 2025

I'll give it a shot and see what I come up with :)

Instead of our $extras var be a list, we will write it as the combination
of --extra ? and no extra flags for uv. Then we can skip the two separate
install steps, and run uv using the --with and $extras flags.

uv build/publish does not have the same kind of check as `twine check` so
that has not been updated yet.
@kfdm kfdm force-pushed the dependency-groups branch from 341e69a to 0351f86 Compare December 17, 2025 08:46
@kfdm
Copy link
Contributor Author

kfdm commented Dec 17, 2025

I have not touched the build/publish bits since that might be better to test in its own commit due to better test with the github artifcat and pypi-publish actions, but this should cover the pytest bits.

@kfdm kfdm marked this pull request as ready for review December 17, 2025 08:56
Copy link
Owner

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, that looks clean, thanks! 🥇

I wouldn't touch the release, since I don't wish to use uv's build backend.

@codingjoe codingjoe enabled auto-merge (squash) December 17, 2025 11:36
@codingjoe codingjoe disabled auto-merge December 17, 2025 11:36
@codingjoe
Copy link
Owner

FYI, @kfdm consider using a ssh-ed25519 to sign your GIT commits. I will bypass the branch rules, but code signing is a good thing in a world of supply chain attacks.

@codingjoe codingjoe merged commit c16b3cc into codingjoe:main Dec 17, 2025
11 checks passed
codingjoe added a commit that referenced this pull request Dec 17, 2025
UV will install the correct python version for us
codingjoe added a commit that referenced this pull request Dec 17, 2025
UV will install the correct python version for us
codingjoe added a commit that referenced this pull request Dec 17, 2025
UV will install the correct python version for us
codingjoe added a commit that referenced this pull request Dec 17, 2025
UV will install the correct python version for us
codingjoe added a commit that referenced this pull request Dec 17, 2025
UV will install the correct python version for us
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants